Comments on: Cleanup of manual animation via Dojo Animation http://almaer.com/blog/cleanup-of-manual-animation-via-dojo-animation blogging about life, the universe, and everything tech Sat, 08 Sep 2012 07:06:53 -0700 http://wordpress.org/?v=2.8.4 hourly 1 By: Peter Higgins http://almaer.com/blog/cleanup-of-manual-animation-via-dojo-animation/comment-page-1#comment-41520 Peter Higgins Tue, 28 Jul 2009 01:12:46 +0000 http://almaer.com/blog/?p=2485#comment-41520 Nice. This is exactly what I had in mind when I'd suggested it. I had meant for you to simply remind me to send in a patch, but you seem to have done just fine. Just as a note, dojo._Animation is private in 1.0 - 1.3, but in 1.4 will be exposed as dojo.Animation (with an alias to preserve backwards compatibility, in typical Dojo style) You have an extra } in _Animation block, fwiw. Regards Nice.

This is exactly what I had in mind when I’d suggested it. I had meant for you to simply remind me to send in a patch, but you seem to have done just fine.

Just as a note, dojo._Animation is private in 1.0 – 1.3, but in 1.4 will be exposed as dojo.Animation (with an alias to preserve backwards compatibility, in typical Dojo style)

You have an extra } in _Animation block, fwiw.

Regards

]]> By: Andrea Giammarchi http://almaer.com/blog/cleanup-of-manual-animation-via-dojo-animation/comment-page-1#comment-41519 Andrea Giammarchi Mon, 27 Jul 2009 21:40:07 +0000 http://almaer.com/blog/?p=2485#comment-41519 Well, at this point I guess that's the cleanest/best way and a nice one. This kind of fx is in any case a common one, so the only thing I could think about is an extension with a parameter for the image in order to spinIn and spinOut the image adding every other callback implementable. P.S. I had an absolutely weird behavior with FF3.5 and only the first time when the image entered starting from a different angle (less than zero) and I could even notice different fillRect colors as squares ... silly of me not a shot, sorry for that! Well, at this point I guess that’s the cleanest/best way and a nice one. This kind of fx is in any case a common one, so the only thing I could think about is an extension with a parameter for the image in order to spinIn and spinOut the image adding every other callback implementable.

P.S. I had an absolutely weird behavior with FF3.5 and only the first time when the image entered starting from a different angle (less than zero) and I could even notice different fillRect colors as squares … silly of me not a shot, sorry for that!

]]> By: dion http://almaer.com/blog/cleanup-of-manual-animation-via-dojo-animation/comment-page-1#comment-41518 dion Mon, 27 Jul 2009 21:25:14 +0000 http://almaer.com/blog/?p=2485#comment-41518 Ah nice, fixed. In the real code it is actually doing a bit more.... Thanks Andrea :) Ah nice, fixed. In the real code it is actually doing a bit more….

Thanks Andrea :)

]]> By: Andrea Giammarchi http://almaer.com/blog/cleanup-of-manual-animation-via-dojo-animation/comment-page-1#comment-41517 Andrea Giammarchi Mon, 27 Jul 2009 21:19:50 +0000 http://almaer.com/blog/?p=2485#comment-41517 <blockquote> I am sure there is an easier way too! </blockquote> Sure, that callback as is is redundant ;-) <code> new dojo._Animation({ duration: 500, easing: dojo.fx.easing.backOut, curve: [0.0, 1.0], onAnimate:renderPie }).play(); </code>

I am sure there is an easier way too!

Sure, that callback as is is redundant ;-)

new dojo._Animation({
duration: 500,
easing: dojo.fx.easing.backOut,
curve: [0.0, 1.0],
onAnimate:renderPie
}).play();

]]>